DOC: added example to Series.map showing use of na_action parameter (GH14231) #14232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 85.24% (diff: 100%)@@ master #14232 diff @@
==========================================
Files 140 140
Lines 50559 50559
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43099 43100 +1
+ Misses 7460 7459 -1
Partials 0 0
|
| @@ -2101,8 +2101,16 @@ def map(self, arg, na_action=None): | |||
| na_action : {None, 'ignore'} | |||
| If 'ignore', propagate NA values | |||
There was a problem hiding this comment.
Can you maybe add here "without passing them to the mapper" or something? (not sure about 'mapper', but not directly thinking of a better word).
There was a problem hiding this comment.
Great suggestion. Updated and squashed commits.
…additional example to Series.map that shows use of na_action parameter. added text to parameter description
shawnheide
force-pushed
the
DOC_14231
branch
from
d0ed42c to
b847717
Compare
jorisvandenbossche
changed the title
|
@shawnheide Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffAdded example to Series.map showing use of na_action parameter.