DOC: #14195. to_csv warns regarding quoting behaviour for floats #14228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a small warning that if `float_format` is set then floats will be quoted even if csv.QUOTE_NONNUMERIC is set
|
The linter complains about some trailing whitespace (hence the travis failure) |
|
Can you also update this in |
|
Sorry - sure |
Added a small warning that if 'float_format' is set then floats will be quoted even if csv.QUOTE_NONNUMERIC is set
Current coverage is 85.24% (diff: 100%)@@ master #14228 diff @@
==========================================
Files 140 140
Lines 50559 50559
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43099 43100 +1
+ Misses 7460 7459 -1
Partials 0 0
|
Added a small warning that if float_format is set then floats will be quoted even if csv.QUOTE_NONNUMERIC is set
|
lgtm. @jorisvandenbossche |
|
Yes, looks good. @theultimatecrouton Thanks! |
yarikoptic
added a commit
to neurodebian/pandas
that referenced
this pull request
Oct 13, 2016
* commit 'v0.19.0-14-ga40e185': (37 commits) BUG: Bug in localizing an ambiguous timezone when a boolean is passed Convert readthedocs links for their .org -> .io migration for hosted projects (pandas-dev#14406) DOC: formatting in basics.rst BLD/CI: cython cache pxd files (pandas-dev#14363) BUG: set_levels set illegal levels. (pandas-dev#14236) DOC: add whitespace to v0.19.1 bug fix section change impl details slightly for pandas-dev#14292 BUG: Fix concat key name DOC: add 0.19.1 whatsnew file (pandas-dev#14366) DOC: to_csv warns regarding quoting behaviour for floats pandas-dev#14195 (pandas-dev#14228) DOC: fix formatting issue with msgpack table TST: pandas-dev#14345 fixes TestDatetimeIndexOps test_nat AssertionErrors on 32-bit docs: Remove old warning from dsintro.rst (pandas-dev#14365) DOC: minor v0.19.0 whatsnew corrections RLS: v0.19.0 DOC: update release notes DOC: Latest fixes for whatsnew file to_latex encoding follows the documentation (py2 ascii, py3 utf8) (pandas-dev#14329) DOC: fix some sphinx build issues (pandas-dev#14332) TST: fix period tests for numpy 1.9.3 (GH14183) (pandas-dev#14331) ...
tworec
pushed a commit
to RTBHOUSE/pandas
that referenced
this pull request
Oct 21, 2016
…4195 (pandas-dev#14228) Added a small warning that if `float_format` is set then floats will be quoted even if csv.QUOTE_NONNUMERIC is set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffAdded a small warning that if
float_formatis set then floats will be quoted even if csv.QUOTE_NONNUMERIC is set