BUG: fix str.contains for series containing only nan values #14182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| convert = False | ||
| else: | ||
| convert = True | ||
| result = lib.map_infer_mask(arr, f, mask.view(np.uint8), convert) |
There was a problem hiding this comment.
just do convert = mask.all()
Current coverage is 85.24% (diff: 100%)@@ master #14182 diff @@
==========================================
Files 140 140
Lines 50549 50550 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43090 43091 +1
Misses 7459 7459
Partials 0 0
|
josh-howes
force-pushed
the
bugfix/14171-series-str-contains-only-nan-values
branch
from
b4a5219 to
c7e9721
Compare
|
thanks! nicely done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff