DEPR: Deprecated PeriodIndex.to_datetime #14113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 85.27% (diff: 100%)@@ master #14113 diff @@
==========================================
Files 139 139
Lines 50511 50513 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43071 43074 +3
+ Misses 7440 7439 -1
Partials 0 0
|
Deprecation is in favour of PeriodIndex.to_timestamp.
gfyoung
force-pushed
the
index-to-datetime-depr-cont
branch
from
876d72c to
9fd85bb
Compare
|
@jreback , @jorisvandenbossche : Travis is passing. Ready to merge if there are no other concerns. |
|
lgtm |
5 tasks
|
Thanks! |
|
Don't forget to add to the list in #6581! |
|
@gfyoung Already did :-) (but linked to the issue, where the links are to all the different prs) |
1 task
gfyoung
added a commit
to forking-repos/pandas
that referenced
this pull request
Dec 5, 2017
Removes the following .to_datetime methods * Index.to_datetime * Timestamp.to_datetime * PeriodIndex.to_datetime * DatetimeIndex.to_datetime All were deprecated in 0.19.0 xref pandas-devgh-8254, pandas-devgh-14096, pandas-devgh-14113
gfyoung
added a commit
to forking-repos/pandas
that referenced
this pull request
Dec 6, 2017
Removes the following .to_datetime methods * Index.to_datetime * NaTType.to_datetime * Timestamp.to_datetime * PeriodIndex.to_datetime * DatetimeIndex.to_datetime All were deprecated in 0.19.0 xref pandas-devgh-8254, pandas-devgh-14096, pandas-devgh-14113
gfyoung
added a commit
that referenced
this pull request
Dec 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #14096 by deprecating
PeriodIndex.to_datetimein favour ofPeriodIndex.to_timestamp.Also addresses #8254.