Skip to content

BUG: fix tz-aware datetime convert to DatetimeIndex (GH 14088) #14090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

conquistador1492
Copy link
Contributor

@@ -267,6 +267,14 @@ def test_operators_timedelta64(self):
rs[2] += np.timedelta64(timedelta(minutes=5, seconds=1))
self.assertEqual(rs[2], value)

# GH 14088
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test also with Timestamp, add a NaT in s.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jreback Done

@jreback jreback added Bug Timedelta Timedelta data type Timezones Timezone data dtype labels Aug 26, 2016
@codecov-io
Copy link

codecov-io commented Aug 26, 2016

Current coverage is 85.26% (diff: 100%)

Merging #14090 into master will decrease coverage by <.01%

@@             master     #14090   diff @@
==========================================
  Files           139        139          
  Lines         50492      50492          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          43053      43052     -1   
- Misses         7439       7440     +1   
  Partials          0          0          

Powered by Codecov. Last update 185fcbe...c91425b

@jreback jreback closed this in d8cd33b Sep 8, 2016
@jreback jreback added this to the 0.19.0 milestone Sep 8, 2016
@jreback
Copy link
Contributor

jreback commented Sep 8, 2016

thanks!

@conquistador1492 conquistador1492 deleted the issue_14088 branch September 8, 2016 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Timedelta Timedelta data type Timezones Timezone data dtype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot subtract tz-aware datetime.datetime from tz-aware datetime64 series.
3 participants