BUG: Don't parse index column as numeric when parse_dates=True #14077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
force-pushed
the
thousands-parse-date-index-col
branch
from
b7cfef0 to
68ecee3
Compare
|
this is related to #9435 (though don't think this fixes) |
| @@ -1474,6 +1474,13 @@ def _set(x): | |||
| else: | |||
| _set(val) | |||
|
|
|||
| elif self.parse_dates: | |||
| if isinstance(self.index_col, list): | |||
There was a problem hiding this comment.
is_list_like? (I don't know if its coerced to a list before this), same below
There was a problem hiding this comment.
do you need to handle dict at this point? (or is that already transformed)
There was a problem hiding this comment.
index_col can never be a dict per the docs.
If you're referring to parse_dates, parse_dates being a dict has a completely different meaning that is independent of the index_col.
gfyoung
force-pushed
the
thousands-parse-date-index-col
branch
from
68ecee3 to
235d624
Compare
Current coverage is 85.26% (diff: 75.00%)@@ master #14077 diff @@
==========================================
Files 139 139
Lines 50492 50504 +12
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43053 43061 +8
- Misses 7439 7443 +4
Partials 0 0
|
gfyoung
force-pushed
the
thousands-parse-date-index-col
branch
3 times, most recently
from
bce56d0 to
676c606
Compare
When a thousands parameter is specified, if the index column data contains that thousands value for date purposes (e.g. '.'), do not interpret those characters as the thousands parameter. Closes pandas-devgh-14066.
gfyoung
force-pushed
the
thousands-parse-date-index-col
branch
from
676c606 to
f2ed334
Compare
| tm.assert_frame_equal(result, expected) | ||
|
|
||
| expected = DataFrame([[datetime(2016, 4, 15), | ||
| datetime(2013, 9, 16)]], |
There was a problem hiding this comment.
add a dict for parse_dates as well
|
@jreback : Travis is passing, so this is ready to merge if there are no other concerns. |
|
@gfyoung Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a thousands parameter is specified, if the index column data contains that thousands value for date purposes (e.g. '.'), do not interpret those characters as the thousands parameter.
Closes #14066.