BUG, DOC: Fix inconsistencies with scalar na_values in read_csv #14056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
force-pushed
the
single-elt-dict-na
branch
from
2cee6d5 to
f660682
Compare
|
pls update io/excel as well as I believe uses same code |
gfyoung
force-pushed
the
single-elt-dict-na
branch
from
f660682 to
d867313
Compare
|
@jreback : Good point. Fixed. |
Current coverage is 85.27% (diff: 100%)@@ master #14056 diff @@
==========================================
Files 139 139
Lines 50440 50442 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43012 43015 +3
+ Misses 7428 7427 -1
Partials 0 0
|
| na_values : scalar, str, list-like, or dict, default None | ||
| Additional strings to recognize as NA/NaN. If dict passed, specific | ||
| per-column NA values. By default the following values are interpreted | ||
| as NaN: '""" + "', '".join(sorted(_NA_VALUES)) + """'. |
There was a problem hiding this comment.
Can you remove the join here? Concatenating docstrings does not work like this (as I experienced when reviewing the other PR which added this).
And I don't think it is worth it for TextParser (not a very public class) to separate the docstring like is done for read_csv)
Update documentation to state that scalars are accepted for na_values. In addition, accept scalars for the values when a dictionary is passed in for na_values. Closes pandas-devgh-12224.
gfyoung
force-pushed
the
single-elt-dict-na
branch
from
d867313 to
7f253f2
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
na_valuesna_valuesCloses #12224.