BUG: Don't error when usecols is a numpy array #14055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.usecols = _validate_usecols_arg(kwds['usecols']) | ||
| if self.usecols is not None: |
There was a problem hiding this comment.
I would do this inside the validate
There was a problem hiding this comment.
Fair enough. Also, it's simpler. Done.
gfyoung
force-pushed
the
np-array-usecols
branch
from
9c9715f to
fe166b7
Compare
Current coverage is 85.26% (diff: 100%)@@ master #14055 diff @@
==========================================
Files 139 139
Lines 50386 50387 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 42959 42960 +1
Misses 7427 7427
Partials 0 0
|
|
@jreback : Simplified the patch, and Travis is still happy. Ready to merge if there is nothing else. |
|
@gfyoung Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts
usecolsto asetjust like we do on the C engine side.Closes #12546.