BUG: DataFrame.to_records() bug in converting datetime64 index #14044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needs tests and a whats new note. |
jreback
added
Bug
Reshaping
|
@jreback Tests for this issue is already present in file pandas/pandas/tests/frame/test_convert_to.py. |
|
if there were tests then your change would fail. pls add them |
|
there are very minimal tests in any event |
Current coverage is 85.26% (diff: 100%)@@ master #14044 diff @@
==========================================
Files 140 140
Lines 50634 50634
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 43173 43173
Misses 7461 7461
Partials 0 0
|
|
@jreback This build with python2.7 failed. But there is not an error with the tests, there is an error with the Travis CI. It shows error like "The command "ci/lint.sh" exited with 1." |
|
you need to lint the code as indicated. |
|
@jreback Build is successful. Please take a look. |
jreback
reviewed
Oct 11, 2016
| df = DataFrame({'datetime': data}) | ||
| df.set_index('datetime', inplace=True) | ||
| dfgmt = df.tz_convert("GMT") | ||
| self.assertNotEqual(df.to_records()['datetime'][0].tzinfo, |
There was a problem hiding this comment.
construct the expected frame and use assert_frame_equal (and same below)
This PR fixes index for datetime64 conversion. Also, update tests - pandas/pandas/tests/tests_convert_to.py Fixes #13937
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG: DataFrame.to_records() bug in converting datetime64 index with timezone #13937