BUG: read_fwf inference should respect skiprows (#11256) #14028
Closed
+101
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.f = f | ||
| self.buffer = None | ||
| self.delimiter = '\r\n' + delimiter if delimiter else '\n\r\t ' | ||
| self.comment = comment | ||
| if skiprows is None: |
There was a problem hiding this comment.
you don't need this here (as you do it below)
There was a problem hiding this comment.
I wasn't sure if the path I was using was the only way these functions were called, but I can remove all but one.
|
can you rebase / update? |
|
@dsm054 Do you have time to update this? |
|
can you rebase / update pls move release note to 0.20.0 |
|
Okay, will have another look at this now while rooting for Clemson. |
dsm054
force-pushed
the
bugfix/fwf_skiprows
branch
from
11aa4e3 to
b5b3e66
Compare
Current coverage is 84.77% (diff: 95.00%)@@ master #14028 diff @@
==========================================
Files 145 145
Lines 51212 51220 +8
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43413 43421 +8
Misses 7799 7799
Partials 0 0
|
|
thanks @dsm054 if you want to do a followup to handle and I guess |
AnkurDedania
pushed a commit
to AnkurDedania/pandas
that referenced
this pull request
Mar 21, 2017
Fix the fact that we don't skip the rows when inferring colspecs by passing skiprows down the chain until it's needed. - [X] closes pandas-dev#11256 - [X] 3 tests added / passed - [X] passes `git diff upstream/master | flake8 --diff` - [X] whatsnew entry Author: D.S. McNeil <[email protected]> Closes pandas-dev#14028 from dsm054/bugfix/fwf_skiprows and squashes the following commits: b5b3e66 [D.S. McNeil] BUG: read_fwf inference should respect skiprows (pandas-dev#11256)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the fact that we don't skip the rows when inferring colspecs by passing skiprows down the chain until it's needed.
git diff upstream/master | flake8 --diff