Skip to content

TST: add comprehensive coercion tests #14010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sinhrks
Copy link
Member

@sinhrks sinhrks commented Aug 16, 2016

  • tests added / passed
  • passes git diff upstream/master | flake8 --diff

1st attempt to make dtype related tests more comprehensive.

Validate whether tests classes have test methods covering dtype and Series/Index. Some of them are empty yet, going to add it gradually.

@sinhrks sinhrks added Testing pandas testing functions or related to the test suite Dtype Conversions Unexpected or buggy dtype conversions labels Aug 16, 2016
@sinhrks sinhrks added this to the 0.19.0 milestone Aug 16, 2016
@sinhrks sinhrks force-pushed the test_coercion branch 2 times, most recently from ce122c2 to d3546af Compare August 16, 2016 14:32
@codecov-io
Copy link

Current coverage is 85.29% (diff: 100%)

Merging #14010 into master will increase coverage by <.01%

@@             master     #14010   diff @@
==========================================
  Files           139        139          
  Lines         50241      50241          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          42849      42851     +2   
+ Misses         7392       7390     -2   
  Partials          0          0          

Powered by Codecov. Last update 6b7857b...de3eb22

@jreback jreback closed this in 7c0b742 Aug 17, 2016
@jreback
Copy link
Contributor

jreback commented Aug 17, 2016

thanks @sinhrks you are great on these comprehensive tests!

@sinhrks sinhrks deleted the test_coercion branch August 17, 2016 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dtype Conversions Unexpected or buggy dtype conversions Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants