Use DeprecationWarning for core.common deprecations (GH13634) #13990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
Current coverage is 85.28% (diff: 100%)@@ master #13990 diff @@
==========================================
Files 139 139
Lines 50206 50206
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 42818 42818
Misses 7388 7388
Partials 0 0
|
|
thanks @jorisvandenbossche I made a slight doc update. |
|
Thanks! |
Closed
TomAugspurger
added a commit
to TomAugspurger/pandas
that referenced
this pull request
Jan 18, 2018
I have a PR incoming that would introduce a circular dependency between pandas.core.arrays.categorical, pandas.api, and pandas.core.common. This change will allow that PR to avoid hacky workarounds, since the real problem is pandas.core importing pandas.api.types. xref pandas-dev#13990
jreback
added a commit
to jreback/pandas
that referenced
this pull request
Feb 19, 2018
jreback
added a commit
to jreback/pandas
that referenced
this pull request
Feb 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to second question in #13634 (whether to use FutureWarning or DeprecationWarning in deprecating the public pandas.core.common functions).
As those functions are mostly used in library code, and less directly by users in their own code, I think a DeprecationWarning is more appropriate in this case.
For example, in our own docs, we started to get warnings due to an example with a statsmodels regression that uses patsy using one of those functions. Note that recent IPython also shows DeprecationWarnings when using a deprecated function interactively.