TST: Cleanup test_indexing #13982
Closed
TST: Cleanup test_indexing #13982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinhrks
added
Testing
Current coverage is 85.28% (diff: 100%)@@ master #13982 diff @@
==========================================
Files 139 139
Lines 50206 50206
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 42818 42818
Misses 7388 7388
Partials 0 0
|
|
@sinhrks Did you just move part of the file test_indexing.py to a new file (split up)? (github won't show the diff ..) |
|
Yeah moved some tests to another file and fixed formats. Doesn't change tests itself. |
|
thanks @sinhrks you are really putting lots of PR's up! fantastic! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffcleaned up
test_indexingwhich is bit large, splitting@slowtests to a separate file.