Skip to content

TST: Removed regex warning for read_csv #13943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Aug 9, 2016

Follow-up to #13481 and partially fixes #13932. Regex mistakenly matches to the empty string, which will cause Python 3.x to issue a warning. In addition, not sure why this test was placed in python_parsers_only.py...

@codecov-io
Copy link

Current coverage is 85.30% (diff: 100%)

Merging #13943 into master will decrease coverage by <.01%

@@             master     #13943   diff @@
==========================================
  Files           139        139          
  Lines         50157      50157          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          42785      42784     -1   
- Misses         7372       7373     +1   
  Partials          0          0          

Powered by Codecov. Last update b7abef4...b93325e

@jreback jreback added the IO CSV read_csv, to_csv label Aug 9, 2016
@jreback jreback added this to the 0.19.0 milestone Aug 9, 2016
@jreback
Copy link
Contributor

jreback commented Aug 9, 2016

ty!

@jreback jreback closed this in e89a0a0 Aug 9, 2016
@gfyoung gfyoung deleted the regex-empty-match branch August 10, 2016 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO CSV read_csv, to_csv
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLN: resource warnings
3 participants