Skip to content

BLD: Fix sparse warnings #13942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

sinhrks
Copy link
Member

@sinhrks sinhrks commented Aug 8, 2016

Because sparse IntIndex and BlockIndex store value locations as int32, its size / block numbers can't exceed int32 also.

warnings has been disappeared in appveyor.

@sinhrks sinhrks added Build Library building on various platforms Sparse Sparse Data Type labels Aug 8, 2016
@sinhrks sinhrks added this to the 0.19.0 milestone Aug 8, 2016
@codecov-io
Copy link

Current coverage is 85.30% (diff: 100%)

Merging #13942 into master will decrease coverage by <.01%

@@             master     #13942   diff @@
==========================================
  Files           139        139          
  Lines         50157      50157          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          42785      42784     -1   
- Misses         7372       7373     +1   
  Partials          0          0          

Powered by Codecov. Last update b7abef4...16164fe

@jreback jreback closed this in ae26ec7 Aug 9, 2016
@jreback
Copy link
Contributor

jreback commented Aug 9, 2016

thank you sir!

@sinhrks sinhrks deleted the sparse_warnings branch August 9, 2016 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms Sparse Sparse Data Type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants