BUG: pd.to_datetime doesn't raises AttributeError with specific input… #13909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if val.view('i8') == NPY_NAT: | ||
| oresult[i] = NaT | ||
| else: | ||
| oresult[i] = np.nan |
There was a problem hiding this comment.
what are you trying to catch here?
There was a problem hiding this comment.
AttributeError: 'float' object has no attribute 'view'
There was a problem hiding this comment.
i don't think the error is intended. can u fix to handle nan properly?
There was a problem hiding this comment.
you need to do a more explict check, something like:
I don't think it can be anything else.
if PyFloat_Check(val): # we *already* know its a null.
oresult[i] = np.nan
else:
orseult[i] = NaT
conquistador1492
force-pushed
the
issue_12424
branch
from
63cf6e8 to
3597634
Compare
Current coverage is 85.30% (diff: 100%)@@ master #13909 diff @@
==========================================
Files 139 139
Lines 50138 50138
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 42769 42769
Misses 7369 7369
Partials 0 0
|
| @@ -568,6 +568,11 @@ def test_value_counts_datetime_outofbounds(self): | |||
| exp = pd.Series([3, 2, 1], index=exp_index) | |||
| tm.assert_series_equal(res, exp) | |||
|
|
|||
| res = pd.to_datetime(pd.Series(['2362-01-01', np.nan]), | |||
There was a problem hiding this comment.
add the issue number as a comment here
|
pls add a release note as well |
…s when errors='ignore'(pandas-dev#12424)
conquistador1492
force-pushed
the
issue_12424
branch
from
3597634 to
58d3d19
Compare
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff…s when errors='ignore'(#12424)