Skip to content

CLN: Removed trellis rplot #13855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

CLN: Removed trellis rplot #13855

wants to merge 1 commit into from

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Jul 31, 2016 •
edited by jreback
Loading

xref #9357.

Title is self-explanatory.

@gfyoung gfyoung force-pushed the trellis-plot-remove branch from 3c63010 to 9666d4d Compare July 31, 2016 04:30
@gfyoung gfyoung changed the title CLN: Removed rplot CLN: Removed trellis rplot Jul 31, 2016
@codecov-io
Copy link

codecov-io commented Jul 31, 2016 •
edited
Loading

Current coverage is 85.30% (diff: 100%)

No coverage report found for master at a7f7e1d.

Powered by Codecov. Last update a7f7e1d...9666d4d

@sinhrks sinhrks added the Deprecate Functionality to remove in pandas label Jul 31, 2016
@sinhrks sinhrks added this to the 0.19.0 milestone Jul 31, 2016
jorisvandenbossche
jorisvandenbossche reviewed Jul 31, 2016
View reviewed changes
.gitignore
@@ -91,7 +91,6 @@ asv_bench/pandas/
# Documentation generated files #
#################################
doc/source/generated
doc/source/_static
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you leave this one? Many figures are created during doc building that are put inside of this, that otherwise show up in your git status view (files that have to be added to git just have to be force added then)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@jorisvandenbossche
Copy link
Member

I would just remove that entire doc section (or maybe leave in the note it was removed, and put a link to the doc section of the previous release).
If you would keep it, you have to include the png files.

@gfyoung gfyoung force-pushed the trellis-plot-remove branch from 9666d4d to b2ef94d Compare July 31, 2016 15:01
@gfyoung
Copy link
Member Author

gfyoung commented Jul 31, 2016

@jorisvandenbossche : I updated the documentation to include a link to the documentation in 0.18.1. I'm not sure that that is the right link though (in terms of format). How can you even see old versions of the documentation online?

@jorisvandenbossche
Copy link
Member

http://pandas.pydata.org/pandas-docs/version/0.18.1/

You can access it from the front page (pandas.pydata.org)

@gfyoung gfyoung force-pushed the trellis-plot-remove branch from b2ef94d to f657a3f Compare July 31, 2016 15:11
@gfyoung
Copy link
Member Author

gfyoung commented Jul 31, 2016

Okay, good to know! Updated the documentation, so ready to merge if there are no other concerns.

@jreback jreback mentioned this pull request Aug 1, 2016
Closed
@gfyoung gfyoung force-pushed the trellis-plot-remove branch from f657a3f to a4e8b29 Compare August 2, 2016 01:23
jreback
jreback reviewed Aug 2, 2016
View reviewed changes
doc/source/visualization.rst
g.add_legend()

.. image:: _static/rplot-seaborn-example6.png
For more information about Trellis plotting and how to convert your code to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this duplicates the above message, can you consolidate.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@jreback
Copy link
Contributor

jreback commented Aug 2, 2016

is there an issue for this? can you reference at the top.

@gfyoung
Copy link
Member Author

gfyoung commented Aug 2, 2016 •
edited
Loading

There is no associated issue for it.

@jreback
Copy link
Contributor

jreback commented Aug 2, 2016

sure there is; updated.

@gfyoung
Copy link
Member Author

gfyoung commented Aug 2, 2016

Where? I don't see any issue for removing this.

@gfyoung gfyoung force-pushed the trellis-plot-remove branch from a4e8b29 to 51eb652 Compare August 2, 2016 10:41
@jreback
Copy link
Contributor

jreback commented Aug 2, 2016

no we reference the issue that deprecated this, which is what I did.

@gfyoung gfyoung force-pushed the trellis-plot-remove branch from 51eb652 to 5427086 Compare August 2, 2016 10:43
@gfyoung
Copy link
Member Author

gfyoung commented Aug 2, 2016

Ah, I see. Made the doc change FYI.

@jreback jreback closed this in 2f8fea7 Aug 2, 2016
@jreback
Copy link
Contributor

jreback commented Aug 2, 2016

thanks!

@gfyoung gfyoung deleted the trellis-plot-remove branch August 2, 2016 10:57
jreback pushed a commit that referenced this pull request Aug 5, 2016
@gfyoung @jreback
BUG: Ignore the BOM in BOM UTF-8 CSV files
e5ee5d2 
closes #4793
closes #13855
jorisvandenbossche added a commit to jorisvandenbossche/pandas that referenced this pull request Aug 10, 2016
@jorisvandenbossche
DOC: remove rplot seaborn equivalent examples (removed from docs in p…
56d365f 
…andas-dev#13855)
jorisvandenbossche added a commit that referenced this pull request Aug 10, 2016
@jorisvandenbossche
DOC: remove rplot seaborn equivalent example figures (#13954)
7bfc7c4 
* DOC: remove rplot seaborn equivalent examples (removed from docs in #13855)

* DOC: fix some doc build errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.
5 participants
@gfyoung @codecov-io @jorisvandenbossche @jreback @sinhrks