Allow users to specify whether gbq should use standard SQL #13850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthea
changed the title
parthea
force-pushed
the
gbq-enable-standard-sql-dialect
branch
from
4f9fbf2 to
5e17ee9
Compare
Current coverage is 85.27% (diff: 0.00%)@@ master #13850 diff @@
==========================================
Files 139 139
Lines 50011 50014 +3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 42650 42650
- Misses 7361 7364 +3
Partials 0 0
|
| @@ -145,13 +145,14 @@ class GbqConnector(object): | |||
| scope = 'https://www.googleapis.com/auth/bigquery' | |||
|
|
|||
| def __init__(self, project_id, reauth=False, verbose=False, | |||
| private_key=None): | |||
| private_key=None, standard_sql=False): | |||
parthea
force-pushed
the
gbq-enable-standard-sql-dialect
branch
from
5e17ee9 to
fb9a6be
Compare
|
All gbq tests passed locally with my latest commit |
| @@ -4482,6 +4482,12 @@ destination DataFrame as well as a preferred column order as follows: | |||
|
|
|||
| You can toggle the verbose output via the ``verbose`` flag which defaults to ``True``. | |||
|
|
|||
| .. note:: | |||
|
|
|||
There was a problem hiding this comment.
oh j meant make this take a string
maybe standard (or legacy)
parthea
force-pushed
the
gbq-enable-standard-sql-dialect
branch
from
fb9a6be to
1641f07
Compare
|
All gbq tests passed locally. |
sinhrks
added
Enhancement
IO Google
Compat
parthea
force-pushed
the
gbq-enable-standard-sql-dialect
branch
from
1641f07 to
efd6d4b
Compare
|
@jreback |
| @@ -557,6 +557,21 @@ def test_zero_rows(self): | |||
| expected_result = DataFrame(page_array, columns=['title', 'id']) | |||
| self.assert_frame_equal(df, expected_result) | |||
|
|
|||
| def test_standard_sql(self): | |||
| standard_sql = "SELECT DISTINCT id FROM " \ | |||
There was a problem hiding this comment.
can you add a test where you validate legacy? (e.g. that it must be standard/legacy in lowercase)
parthea
force-pushed
the
gbq-enable-standard-sql-dialect
branch
from
efd6d4b to
802dd64
Compare
|
All gbq tests pass with my latest commit. |
| @@ -612,8 +620,12 @@ def read_gbq(query, project_id=None, index_col=None, col_order=None, | |||
| if not project_id: | |||
| raise TypeError("Missing required parameter: project_id") | |||
|
|
|||
| if dialect not in ('legacy', 'standard'): | |||
There was a problem hiding this comment.
did you add a test that exercises this exception?
parthea
force-pushed
the
gbq-enable-standard-sql-dialect
branch
from
802dd64 to
e1fbb07
Compare
|
All gbq tests pass locally with my latest commit |
|
@jreback |
|
thanks @parthea still would like to have some testing actually on travis.....any update / luck with this? (e.g. we would need a test account with google / credentials which we can embed in travis via secure key) |
I have sent an email to Google to see if we can get a test account. I'll post here if I get an update. In the meantime, another (quicker) option would be to create a new Google account through the normal channels which can be used primarily for pandas. There will most likely be a cost associated (Should be < $1 per month, but there is a $200 free trial so costs are not incurred during the first 2 months). Would that work? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffAll gbq tests passed locally