ENH: add sort_categories argument to union_categoricals #13846
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| new_codes = np.concatenate([c.codes for c in to_union]) | ||
|
|
||
| if sort_categories: | ||
| categories = categories.sort_values() |
There was a problem hiding this comment.
I think sort can be skipped if categories is monotonic-increasing.
Current coverage is 85.28% (diff: 100%)@@ master #13846 diff @@
==========================================
Files 140 139 -1
Lines 50455 50020 -435
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 43014 42659 -355
+ Misses 7441 7361 -80
Partials 0 0
|
| # GH 13763 | ||
| c1 = Categorical(['x', 'y', 'z']) | ||
| c2 = Categorical(['a', 'b', 'c']) | ||
| result = union_categoricals([c1, c2], sort_categories=True) |
There was a problem hiding this comment.
can you put companion tests with sort_categories=False
|
can you add this issue to the whatsnew (just add on to same line where |
|
lgtm. @sinhrks pls have a look. |
|
lgtm. pls fix the lint issue:) |
|
@sinhrks - updated, thanks! |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffcc: @JanSchulz, @sinhrks