BUG: fixes 13822, incorrect KeyError string with non-unique columns w… #13845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen missing column is accessed
Current coverage is 85.25% (diff: 100%)@@ master #13845 diff @@
==========================================
Files 140 140
Lines 50455 50456 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43014 43016 +2
+ Misses 7441 7440 -1
Partials 0 0
|
sinhrks
added
Indexing
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffMade changes to fix the bug related to accessing columns in a df with duplicate columns where the KeyError string was returning the wrong column.
The test that I added passed, but there seems to be a test that won't pass and I wasn't sure what's going on. Even on a clean master, when I run "nosetests pandas/tests/indexing/test_indexing.py" I get "ERROR: test_float64index_slicing_bug (pandas.tests.indexing.test_indexing.TestIndexing)".