TST: A test to cover fault in issue #5291 #13833
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivannz
changed the title
Current coverage is 85.25% (diff: 100%)@@ master #13833 diff @@
==========================================
Files 140 140
Lines 50451 50455 +4
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43003 43015 +12
+ Misses 7448 7440 -8
Partials 0 0
|
sinhrks
added
Testing
Provides a nicer error message for the Python engine in read_csv when the data contains a NULL byte. Closes pandas-devgh-2741.
gfyoung
added a commit
to forking-repos/pandas
that referenced
this pull request
Nov 6, 2017
gfyoung
added a commit
that referenced
this pull request
Nov 6, 2017
watercrossing
pushed a commit
to watercrossing/pandas
that referenced
this pull request
Nov 10, 2017
No-Stream
pushed a commit
to No-Stream/pandas
that referenced
this pull request
Nov 28, 2017
TomAugspurger
pushed a commit
to TomAugspurger/pandas
that referenced
this pull request
Dec 8, 2017
xref pandas-devgh-13833. Closes pandas-devgh-5291. (cherry picked from commit 6f0ff1a)
TomAugspurger
pushed a commit
that referenced
this pull request
Dec 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mentioned issue faulted under similar conditions as issue #13703, and was also fixed by PR #13788. This PR just adds a test to replicate the fault, as discussed in the issue's thread.
git diff upstream/master | flake8 --diffThis PR also corrects accidental use of float("nan") instead of np.nan in
test_parse_trim_buffers.