TST: Add test for skipfooter + decimal in read_csv #13800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
added
Testing
Current coverage is 85.23% (diff: 100%)@@ master #13800 diff @@
==========================================
Files 140 140
Lines 50415 50415
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 42970 42970
Misses 7445 7445
Partials 0 0
|
|
can you replicate the test in the associated issue as well. |
gfyoung
force-pushed
the
test-skipfooter-decimal
branch
from
e1a849d to
f1ded8c
Compare
|
@jreback : Ah, yes, good point. Done. |
|
thanks @gfyoung |
|
Also got a nice, round number for this PR as a bonus! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title is self-explanatory. Only for Python engine because C engine doesn't support
skipfooteryet.Closes #6971.