-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CLN: Removed SparsePanel #13778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLN: Removed SparsePanel #13778
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -542,26 +542,6 @@ def test_sparse_frame(self): | |
self._check_roundtrip(ss3, tm.assert_frame_equal, | ||
check_frame_type=True) | ||
|
||
def test_sparse_panel(self): | ||
|
||
with tm.assert_produces_warning(FutureWarning, | ||
check_stacklevel=False): | ||
|
||
items = ['x', 'y', 'z'] | ||
p = Panel(dict((i, tm.makeDataFrame().ix[:2, :2]) for i in items)) | ||
sp = p.to_sparse() | ||
|
||
self._check_roundtrip(sp, tm.assert_panel_equal, | ||
check_panel_type=True) | ||
|
||
sp2 = p.to_sparse(kind='integer') | ||
self._check_roundtrip(sp2, tm.assert_panel_equal, | ||
check_panel_type=True) | ||
|
||
sp3 = p.to_sparse(fill_value=0) | ||
self._check_roundtrip(sp3, tm.assert_panel_equal, | ||
check_panel_type=True) | ||
|
||
|
||
class TestCompression(TestPackers): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. hmm I think we have legacy pickled / msgpacks that DO serialize this, so need to ignore that NotImplementedError when checking (IOW in io/tests/test_pickle.py) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't really follow. How are we supposed to test pickling There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. well if u have a class that doesn't exist and you try to unpickle it will fail now I don't know if these are actually saved in pickles (maybe not) so may be moot There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As I mentioned below, I don't believe that there are any pickles for |
||
"""See https://github.com/pydata/pandas/pull/9783 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2688,23 +2688,6 @@ def test_sparse_frame(self): | |
self._check_double_roundtrip(ss3, tm.assert_frame_equal, | ||
check_frame_type=True) | ||
|
||
def test_sparse_panel(self): | ||
|
||
items = ['x', 'y', 'z'] | ||
p = Panel(dict((i, tm.makeDataFrame().ix[:2, :2]) for i in items)) | ||
sp = p.to_sparse() | ||
|
||
self._check_double_roundtrip(sp, assert_panel_equal, | ||
check_panel_type=True) | ||
|
||
sp2 = p.to_sparse(kind='integer') | ||
self._check_double_roundtrip(sp2, assert_panel_equal, | ||
check_panel_type=True) | ||
|
||
sp3 = p.to_sparse(fill_value=0) | ||
self._check_double_roundtrip(sp3, assert_panel_equal, | ||
check_panel_type=True) | ||
|
||
def test_float_index(self): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here, these exist in the legacy file (I think) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. GitHub search says otherwise. Also, not in the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it's possible these were never put there There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well, unless specific files can be pointed out, a GitHub search is sufficient to convince me that they are not there. Not to mention, there would have been test failures because all legacy pickles should be tested (this was the same issue with the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no a search is not sufficient you always have to assume other people don't do things and test everything |
||
|
||
# GH #454 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add a warning note somewhere that
SparsePanel
was deprecated in 0.19.0There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean "removed in
0.19.0
" ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes