DOC: some general doc/sphinx fixes #13740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name='foo')) | ||
|
|
||
| dft = pd.DataFrame({'B': [0, 1, 2, np.nan, 4]}, | ||
| index = pd.Index([pd.Timestamp('20130101 09:00:00'), |
There was a problem hiding this comment.
do we still have * imports anywhere? (otherwise this should have broken)
There was a problem hiding this comment.
It was broken :-) (as I noticed in the travis doc build log, otherwise I wouldn't have catched this)
There was a problem hiding this comment.
haha, makes sense! good that these raise (though didn't seem to fail the travis build) :<
There was a problem hiding this comment.
no, currently the travis build does not fail for such errors. But in principle we could do a search for certain patterns in the doc build log and let travis fail based on that
|
lgtm |
jorisvandenbossche
force-pushed
the
doc-fixes
branch
from
479fe8a to
1c70bb3
Compare
jorisvandenbossche
force-pushed
the
doc-fixes
branch
from
1c70bb3 to
665cee1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.