TST/BUG: test unsortable in safe_sort and Categorical (GH13714) #13733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change test for Categorical.from_array - Add test for safe_sort - Change 2.7 build to latest numpy
| @@ -116,6 +117,19 @@ def test_mixed_integer(self): | |||
| labels = [0, 1, 2, 3, 0, -1, 1] | |||
| result, result_labels = algos.safe_sort(values, labels) | |||
| expected = np.array([0, 1, 'a', 'b'], dtype=object) | |||
| expected_labels = np.array([3, 1, 0, 2, 3, -1, 1]) | |||
| tm.assert_numpy_array_equal(result, expected) | |||
| tm.assert_numpy_array_equal(result_labels, expected_labels) | |||
There was a problem hiding this comment.
Unrelated. (These three lines where lost in #13514.)
jreback
added
the
Compat
|
closed by 622297c thanks! |
|
FYI we have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --difftest_constructor_unsortable)safe_sortalways raises on a mixed int-datetime array. This is the expected behaviour. (But, for numpy >= 1.10 & python2, I still have some doubts whether it's not a manifestation of an undefined behaviour.)