Groupby getitem works with all index types #13731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcrist
force-pushed
the
groupby-getitem-int64index
branch
from
a4a8d41 to
29185e4
Compare
Current coverage is 84.56% (diff: 100%)@@ master #13731 diff @@
==========================================
Files 141 141
Lines 51195 51196 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43295 43296 +1
Misses 7900 7900
Partials 0 0
|
| @@ -3769,6 +3769,21 @@ def test_getitem_list_of_columns(self): | |||
| assert_frame_equal(result2, expected) | |||
| assert_frame_equal(result3, expected) | |||
|
|
|||
| def test_getitem_numeric_column_names(self): | |||
| df = DataFrame({0: list('abcd') * 2, | |||
There was a problem hiding this comment.
Can you add the issue number (or in this case PR number) as a comment on the first line?
|
Looks good to me, some minor comments |
|
yep lgtm. |
Previously `df.groupby(0)[df.columns]` would fail if all column names were integers (meaning `df.columns` was an `Int64Index`). This was because the implementation of `__getitem__` in `SelectionMixin` was checking for `ABCIndex` when it probably should have checked for `ABCIndexClass`.
jcrist
force-pushed
the
groupby-getitem-int64index
branch
from
29185e4 to
b901322
Compare
|
Thanks, fixed. |
|
lgtm |
|
@jcrist Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffPreviously
df.groupby(0)[df.columns]would fail if all column nameswere integers (meaning
df.columnswas anInt64Index). This wasbecause the implementation of
__getitem__inSelectionMixinwaschecking for
ABCIndexwhen it probably should have checked forABCIndexClass.