PERF: Improve Period hashing #13705
Closed
PERF: Improve Period hashing #13705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinhrks
added
Performance
| @@ -2164,6 +2226,28 @@ def test_drop_duplicates_metadata(self): | |||
| self.assert_index_equal(idx, result) | |||
| self.assertEqual(idx.freq, result.freq) | |||
|
|
|||
| def test_drop_duplicates(self): | |||
| # to check Index/Series compat | |||
| base = pd.period_range('2011-01-01', '2011-01-31', freq='D', | |||
There was a problem hiding this comment.
is this duplicated code with above?
There was a problem hiding this comment.
no, the code directly above intends to check metadata. others look similar are for datetime/timedelta. though we have index/series separated tests, I thinks it's good chance to check index/series compat.
|
i think this needs a rebase |
Current coverage is 84.54%@@ master #13705 diff @@
==========================================
Files 141 141
Lines 51161 51161
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 43252 43252
Misses 7909 7909
Partials 0 0
|
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff