MAINT: Removed some warnings in tests

[gfyoung]

Per discussion with @jreback here.

[jreback]

this is an incorrect construction, categories should not be nan by definition

[gfyoung]

The test is expecting a nan in the construction of the categories if you look at what it is testing.

[jreback]

and that's wrong

[gfyoung]

Ah, okay. Fair enough. Done.

[codecov-io]

Current coverage is 84.52%

Merging #13702 into master will decrease coverage by <.01%

@@             master     #13702   diff @@
==========================================
  Files           141        141          
  Lines         51145      51145          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          43233      43230     -3   
- Misses         7912       7915     +3   
  Partials          0          0          

Powered by Codecov. Last updated by 8acfad3...e7292d3

[gfyoung]

@jreback : it seems like test_categorical.py has A LOT of tests where they expect to use np.nan as a category. Does it make sense to modify / remove them?

[jreback]

can't be very many as we have a warning for it
I only see a few

[gfyoung]

1. A Ctrl+F returns 30+ results (all of them caught with tm.assert_produces_warnings(FutureWarning)
   of course).
2. So is that a yes or no?

[jreback]

there are warnings but should not be from that

pls show an example or 2

[gfyoung]

1. Constructor tests here (just testing that duplicates get rejected)

2. Describing with NaN categories here

3. Another constructor test here.

4. This entire test here.

5. Setter tests here.

Perhaps I'm conflating unnecessary tests with backwards compat tests since the code still has to work with this deprecated behaviour, not sure...

[jreback]

yeah these are all fine
when this behavior is removed in the future the tests can be changed

for now since we have enough catching of the warning
prob just fix the examples that were causing a warning (rather than catch them)

[gfyoung]

Okay, sounds good. I'll fix the other one then.

[gfyoung]

@jreback : Removed the previous warnings, and Travis is still passing. Ready to merge if there are no other concerns.

[jreback]

ty!