Enh tests compat pytables 2.1 #137
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Got it-- I can merge this later tonight. Are you OK with packaging the 0.4.0 release with your patches? Doesn't strike me that a bugfix release should be necessary. |
|
sure -- I can absorb all those into a patch queue ;-)
|
|
Cherry picked these commits. Thanks! |
dan-nadler
pushed a commit
to dan-nadler/pandas
that referenced
this pull request
Sep 23, 2019
Keep writing base_sha for backwards compatibility
3 tasks
3 tasks
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unfortunately on Debian systems we still have pytables 2.1; but it still would be nice to have pandas' unittests to pass with skips but without an error or failure -- major incompatibility is absense of blosc compressor. This changes make those tests conditional on the version of pytables being at least 2.2 to test blosc