COMPAT: use mpl area legend if available #13680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinhrks
added
Visualization
Current coverage is 85.30% (diff: 72.72%)@@ master #13680 diff @@
==========================================
Files 139 139
Lines 50143 50146 +3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 42776 42776
- Misses 7367 7370 +3
Partials 0 0
|
|
Looks good to me. @TomAugspurger Can you have a look? |
| # need to remove label, because subplots uses mpl legend as it is | ||
| line_kwds = kwds.copy() | ||
| if cls.mpl_ge_1_5_0(): | ||
| line_kwds.pop('label') |
There was a problem hiding this comment.
Is this worth warning over? Seems similar to the subplots=True, axes=... case, which we do warn about.
There was a problem hiding this comment.
Oh, I see below you were moving that from below. Never mind then.
|
Just the one question, but not really relevant to this PR. +1 Oh, might want a whatsnew entry. |
sinhrks
force-pushed
the
plot_area_legend
branch
from
ffbaabb to
968aecc
Compare
|
@TomAugspurger status of this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffDo not use area legend workaround if mpl >= 1.5.0 is available. Legends are now displayed properly if mpl >= 1.5.0.
#9161:
#13544: