Skip to content

TST: assert message shows unnecessary diff #13676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2016

Conversation

sinhrks
Copy link
Member

@sinhrks sinhrks commented Jul 16, 2016

  • passes git diff upstream/master | flake8 --diff

removed unnecessary trailing None.

pd.util.testing.assert_index_equal(pd.Index([1, 2, 3]), pd.Index([1 ,2, 4]))
# AssertionError: Index are different
# 
# Index values are different (33.33333 %)
# [left]:  Int64Index([1, 2, 3], dtype='int64')
# [right]: Int64Index([1, 2, 4], dtype='int64')None

@sinhrks sinhrks added the Testing pandas testing functions or related to the test suite label Jul 16, 2016
@sinhrks sinhrks added this to the 0.19.0 milestone Jul 16, 2016
@codecov-io
Copy link

codecov-io commented Jul 16, 2016

Current coverage is 84.38%

Merging #13676 into master will increase coverage by <.01%

@@             master     #13676   diff @@
==========================================
  Files           142        142          
  Lines         51223      51223          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43223      43224     +1   
+ Misses         8000       7999     -1   
  Partials          0          0          

Powered by Codecov. Last updated by d7c028d...bdfd2cc

@jreback jreback merged commit 6b9cd15 into pandas-dev:master Jul 18, 2016
@jreback
Copy link
Contributor

jreback commented Jul 18, 2016

yes this was annoying!

@sinhrks sinhrks deleted the test_assert branch July 18, 2016 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants