DOC: resample warnings #13675
Closed
DOC: resample warnings #13675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinhrks
added
Error Reporting
Current coverage is 84.38%@@ master #13675 diff @@
==========================================
Files 141 142 +1
Lines 51185 51225 +40
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 43275 43226 -49
- Misses 7910 7999 +89
Partials 0 0
|
|
lgtm. I would add at the very least a bug fix note. I don't think anything is warranted unless you think a user would be suprised by the change in deprecation warning. |
chris-b1
force-pushed
the
resample-warning
branch
from
f26dcf1 to
2185c1f
Compare
|
@jreback - added a doc note - not sure why travis didn't run, but that's the only change. I didn't think there needs to be any doc change on the deprecation warning, it's basically saying the same thing, just more verbose. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffPrevents warnings triggered by IPython by matching against
'_repr'or'_ipython', and expands theresamplewarning message to indicate what caused the deferred object to be materialized.