Skip to content

BUG: Invalid Timedelta op may raise ValueError #13624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sinhrks
Copy link
Member

@sinhrks sinhrks commented Jul 11, 2016

  • tests added / passed
  • passes git diff upstream/master | flake8 --diff
  • whatsnew entry

Timedelta op may raise ValueError for invalid inputs because of internal conversion.

pd.Timedelta('1 days') + 'a'
# ValueError: unit abbreviation w/o a number

Now it raises TypeError.

@sinhrks sinhrks added Bug Error Reporting Incorrect or improved errors from pandas Timedelta Timedelta data type labels Jul 11, 2016
@sinhrks sinhrks added this to the 0.19.0 milestone Jul 11, 2016
@codecov-io
Copy link

codecov-io commented Jul 12, 2016

Current coverage is 84.33%

Merging #13624 into master will increase coverage by <.01%

@@             master     #13624   diff @@
==========================================
  Files           138        138          
  Lines         51100      51104     +4   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43097      43101     +4   
  Misses         8003       8003          
  Partials          0          0          

Powered by Codecov. Last updated by 65849d3...856df95

@jreback jreback closed this in 93b7d13 Jul 12, 2016
@sinhrks sinhrks deleted the timedelta_comp branch July 12, 2016 10:58
nateGeorge pushed a commit to nateGeorge/pandas that referenced this pull request Aug 15, 2016
Author: sinhrks <[email protected]>

Closes pandas-dev#13624 from sinhrks/timedelta_comp and squashes the following commits:

856df95 [sinhrks] BUG: Invalid Timedelta op may raise ValueError
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Error Reporting Incorrect or improved errors from pandas Timedelta Timedelta data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants