Fix bug in contains when looking up a string in a non-monotonic datet… #13574
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -721,6 +721,17 @@ def test_fillna_datetime64(self): | |
| dtype=object) | ||
| self.assert_index_equal(idx.fillna('x'), exp) | ||
|
|
||
| def test_contains(self): | ||
| #GH13572 | ||
| dates = ['2015-01-03', '2015-01-01', '2015-01-04', '2015-01-05', '2015-01-02'] | ||
| monotonic = pd.to_datetime(sorted(dates)) | ||
| non_monotonic = pd.to_datetime(['2015-01-03', '2015-01-01', '2015-01-04', '2015-01-05', '2015-01-02']) | ||
|
There was a problem hiding this comment. You can reuse There was a problem hiding this comment. How is NaT supposed to work with period indices? >>> pd.Period('NaT', freq='D') in pd.period_range('2015-01-01', periods=5, freq='D').insert(0, pd.NaT)
TrueAny of There was a problem hiding this comment. Thx to confirm. Pls leave other nat-likes ( There was a problem hiding this comment. Hmm, TimedeltaIndices have a funny behavior as well. Checking for NaT-like objects always returns true >>> None in pd.to_timedelta(range(5), unit='d') + pd.offsets.Hour(1)
TrueLooks like There was a problem hiding this comment. I've taken out the timedelta issues as well, and created a new PR #13603. |
||
| for idx in [non_monotonic, monotonic]: | ||
| self.assertNotIn('2015-01-06', idx) | ||
| self.assertNotIn(pd.Timestamp('2015-01-06'), idx) | ||
| for dt in reversed(dates): | ||
| self.assertIn(dt, idx) | ||
| self.assertIn(pd.Timestamp(dt), idx) | ||
|
|
||
| class TestPeriodIndex(DatetimeLike, tm.TestCase): | ||
| _holder = PeriodIndex | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can u also add tests for
TimedeltaIndexandPeriodIndex? (It looks work)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to just move this to the
Datetimelikeclass which tests all datetimelike indexes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
further let's add testing with
Timestampanddatetimeas well (and a case where things are not there). finally add in aNaTboth in the contained index as well as a tests within