TST: Move test_crosstab_margins to TestPivotTable
#13553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
added
the
Testing
|
@yui-knk Seems reasonable indeed. There is one failing test, but you don't need to bother about that (it's data-reader related, they fail once in a while), but there is also a lint error. You just need to add an extra blank line after the test function (pep8). Can you update for that? |
|
lgtm (assume pep is fixed) |
yui-knk
force-pushed
the
test_categorical_margins
branch
from
927e5b7 to
e996e6a
Compare
Current coverage is 84.34%@@ master #13553 diff @@
==========================================
Files 138 138
Lines 51126 51126
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 43122 43122
Misses 8004 8004
Partials 0 0
|
This test case assert `pivot_table` method. So it should be defined on `TestPivotTable`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test case assert
pivot_tablemethod.So it should be defined on
TestPivotTable.