Fixes a missing ".reshape" call #13525
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests! |
Current coverage is 84.33%@@ master #13525 diff @@
==========================================
Files 138 138
Lines 51107 51107
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 43103 43103
Misses 8004 8004
Partials 0 0
|
|
this is actually a non-trivial issue, I suspect this fix will work partially. But need a fair amount of tests. |
jreback
added
Datetime
|
pls reopen if you want to complete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13287
Currently, some 2D arrays can go into _possibly_infer_to_datetimelike and come out 1D. The issue is that the input is ravelled at one point, but only unravelled back to it's original form if a certain path it taken through the function. This pull request adds the same
.reshape(shape)call to the other path through the function.