Skip to content

DOC/WIP: travis notebook doc build #13493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2016
Merged

DOC/WIP: travis notebook doc build #13493

merged 1 commit into from
Jun 23, 2016

Conversation

TomAugspurger
Copy link
Contributor

Just want to see the output log from the pull request.

@TomAugspurger
Copy link
Contributor Author

https://travis-ci.org/pydata/pandas/jobs/139080123

@codecov-io
Copy link

codecov-io commented Jun 21, 2016 •
edited
Loading

Current coverage is 84.33%

Merging #13493 into master will not change coverage

@@             master     #13493   diff @@
==========================================
  Files           138        138          
  Lines         51106      51106          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43102      43102          
  Misses         8004       8004          
  Partials          0          0

Powered by Codecov. Last updated by 30d710f...df6939a

jreback
jreback reviewed Jun 21, 2016
View reviewed changes
ci/requirements-2.7_DOC_BUILD.run
@@ -1,7 +1,9 @@
ipython
ipykernel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can just include notebook and get all of the deps

@jreback jreback added Docs CI Continuous Integration labels Jun 21, 2016
@TomAugspurger
Copy link
Contributor Author

@jorisvandenbossche so my last commit succeeded https://travis-ci.org/pydata/pandas/jobs/139093566#L1569

I'm not sure why the python -m ipykernel install was necessary, I've never had to do that on my own system. I want to look into the correct way to do this, but won't have a chance till tonight or tomorrow.

@jorisvandenbossche
Copy link
Member

Hmm, I am not sure this is due to the installing of the kernel, as the logs say:

python -m ipykernel install
[Errno 13] Permission denied: '/usr/local/share/jupyter'

So I think it is just adding the ipykernel as dependency which was needed?

@TomAugspurger
Copy link
Contributor Author

Ahh, I missed that. Let me retry just using notebook to get everything like Jeff suggested.

@jorisvandenbossche
Copy link
Member

In principle, notebook is not needed (nbconvert and ipykernel should suffice as well), although doesn't hurt of course :-)

jorisvandenbossche
jorisvandenbossche reviewed Jun 23, 2016
View reviewed changes
ci/build_docs.sh
@@ -19,6 +19,8 @@ fi

if [ x"$DOC_BUILD" != x"" ]; then

jupyter-kernelspec list
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed again I think?

@jorisvandenbossche
Copy link
Member

Apart from the clean-up, I think this can be merged?

@TomAugspurger
DOC/BLD: Travis doc build notebook dependencies
73800bb 
Added notebook deps for travis doc build.
@TomAugspurger
Copy link
Contributor Author

@jorisvandenbossche fixed

@jorisvandenbossche jorisvandenbossche added this to the 0.18.2 milestone Jun 23, 2016
@jorisvandenbossche jorisvandenbossche merged commit 48f0c3a into pandas-dev:master Jun 23, 2016
@TomAugspurger
Copy link
Contributor Author

@jorisvandenbossche http://pandas-docs.github.io/pandas-docs-travis/style.html 🎉

A few minor things, like dependencies on ipywidgets and seaborn didn't work. I can do another followup.

@jorisvandenbossche
Copy link
Member

Yes, we're coming closer :-)

Also a unicode thing (just needs a u"" I think)

@TomAugspurger TomAugspurger deleted the styler-doc-fu-3 branch April 5, 2017 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI Continuous Integration Docs
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.
4 participants
@TomAugspurger @codecov-io @jorisvandenbossche @jreback