Skip to content

DOC: find kernelspec #13491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2016
Merged

Conversation

TomAugspurger
Copy link
Contributor

xref #13487

Problem was the notebook was written with a python3 kernel, but the doc build is python2.
There are potentially problems here if you have non-default kernel names in your environment...

@codecov-io
Copy link

codecov-io commented Jun 20, 2016

Current coverage is 84.33%

Merging #13491 into master will not change coverage

@@             master     #13491   diff @@
==========================================
  Files           138        138          
  Lines         51083      51083          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43083      43083          
  Misses         8000       8000          
  Partials          0          0          

Powered by Codecov. Last updated by b01e07e...cb967e1

@jorisvandenbossche jorisvandenbossche added this to the 0.18.2 milestone Jun 20, 2016
@jorisvandenbossche
Copy link
Member

Isn't there a way to say "use the same kernel as the one that is calling me"?
Because this will only work for "python2"/"python3" kernel names, which is OK for travis, but eg locally I build the docs mainly with my 'dev' environment for which I have a kernel named 'dev'

@TomAugspurger
Copy link
Contributor Author

I couldn't find anything like that immediately. Will look tonight.

@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Jun 20, 2016

No matter, if I build the docs from that environment, the kernel will be named python2/3 anyhow, it's only when I select in the notebook the kernel itself (starting the notebook from another environment), that the name of this kernel will be different.

@TomAugspurger
Copy link
Contributor Author

There is a difference between kernel name and display name in the kernelspec

@@ -116,6 +116,11 @@ def cleanup_nb(nb):
pass


def get_kernel():
"""Find kernals starting with ``name``."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit strange docstring

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. That was a leftover from a more complicated implementation I discarded.

@jorisvandenbossche
Copy link
Member

Let's give it another try! :-)

@jorisvandenbossche jorisvandenbossche merged commit 3b75e03 into pandas-dev:master Jun 20, 2016
@TomAugspurger
Copy link
Contributor Author

@jorisvandenbossche
Copy link
Member

Hmm, still not working: "Failed to convert source/html-styling.ipynb" in the logs

@TomAugspurger
Copy link
Contributor Author

Just saw that 😞, I'll look into it more later.

@TomAugspurger TomAugspurger deleted the doc-kernel branch April 5, 2017 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants