Skip to content

BUG: df.pivot_table: margins_name ignored when aggfunc is a list #13435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

BUG: df.pivot_table: margins_name ignored when aggfunc is a list #13435

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d6a6036
BUG: df.pivot_table: margins_name is ignored when there aggfunc is li…
cmazzullo Jun 13, 2016
0dcb78f
Switched documentation to v0.18.2
cmazzullo Jun 14, 2016
669931f
Added unit test for pivot_table margins_name when aggfunc is a list
cmazzullo Jun 15, 2016
98ab8be
Added doublequotes to variable names
cmazzullo Jun 18, 2016
b4b09bf
Compared whole dataframes in test_pivot_table_margins_name_with_aggfu…
cmazzullo Jun 18, 2016
6017e25
Fixed up whitespace for pep8
cmazzullo Jun 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v0.18.1.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,3 +682,4 @@ Bug Fixes
- Bug in ``pd.to_numeric()`` with ``Index`` returns ``np.ndarray``, rather than ``Index`` (:issue:`12777`)
- Bug in ``pd.to_numeric()`` with datetime-like may raise ``TypeError`` (:issue:`12777`)
- Bug in ``pd.to_numeric()`` with scalar raises ``ValueError`` (:issue:`12777`)
- Bug in ``pd.pivot_table()`` where margins_name is ignored when aggfunc is a list (:issue:`13354`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this to whatsnew/0.18.2.txt :)

2 changes: 1 addition & 1 deletion pandas/tools/pivot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def pivot_table(data, values=None, index=None, columns=None, aggfunc='mean',
table = pivot_table(data, values=values, index=index,
columns=columns,
fill_value=fill_value, aggfunc=func,
margins=margins)
margins=margins, margins_name=margins_name)
pieces.append(table)
keys.append(func.__name__)
return concat(pieces, keys=keys, axis=1)
Expand Down