BUG: resample by BusinessHour raises ValueError #13364
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 84.23%@@ master #13364 diff @@
==========================================
Files 138 138
Lines 50724 50727 +3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 42726 42729 +3
Misses 7998 7998
Partials 0 0
|
| @@ -2297,6 +2297,17 @@ def test_upsample_daily_business_daily(self): | |||
| expected = ts.asfreq('H', how='s').reindex(exp_rng) | |||
| assert_series_equal(result, expected) | |||
|
|
|||
| def test_resample_hourly_business_hourly(self): | |||
| ts = pd.Series(index=pd.date_range(start='2016-06-01 03:00:00', | |||
There was a problem hiding this comment.
add the issue number here as a comment
|
can you update |
| elif isinstance(offset, BusinessHour): | ||
| # GH12351 - normalize BH freq leads ValueError | ||
| first = Timestamp(offset.rollback(first)) | ||
| last = Timestamp(offset.rollforward(last + offset)) |
There was a problem hiding this comment.
isn't rollback/rollforward returns Timestamp?
|
@scari Do you have time to rebase and update this? |
|
can you rebase / update? |
|
can you rebase and move release notes to 0.19.2 |
|
can you rebase / move whatsnew to 0.20.0 |
|
closing as stale |
scari
added a commit
to scari/pandas
that referenced
this pull request
Apr 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestPeriodIndex.test_resample_hourly_business_hourly)git diff upstream/master | flake8 --diffI did this during pandas sprint at PyCon 2016. Hope this close #12351
Resampling with BusinessHour took much more consideration I guess.
Please review this. Any comments are welcome.