BUG: Check for NaN after data conversion to numeric #13314
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
force-pushed
the
nan-check-post-numeric-conversion
branch
from
5a15c7f to
9e17995
Compare
Current coverage is 84.22%@@ master #13314 diff @@
==========================================
Files 138 138
Lines 50667 50667
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 42672 42672
Misses 7995 7995
Partials 0 0
|
| @@ -291,6 +291,7 @@ Bug Fixes | |||
|
|
|||
|
|
|||
|
|
|||
| - Bug in ``pd.read_csv()`` with ``engine='python'`` in which NaN values weren't being detected after data was converted to numeric values (:issue:`13314`) | |||
There was a problem hiding this comment.
double backticks around NaN
jreback
added
Missing-data
|
I suspect Can you run related perf tests just to see if any effect. |
|
No need I think: |
|
Ran perf tests on windows and didn't see any noticeable changes |
gfyoung
force-pushed
the
nan-check-post-numeric-conversion
branch
from
9e17995 to
07f0538
Compare
|
@jreback : Made the requested changes, and Travis is giving the green light. Ready to merge if there are no other concerns. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to squash a Python parser bug in which weirdly-formed floats weren't being checked for
nan, the bug was traced back to a bug in themaybe_convert_numericfunction ofpandas/src/inference.pyx. Added tests for the bug intest_lib.pyand adjusted the originalnantests inna_values.pyto test all of the engines.