TST: Make numpy_array test strict #13311
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 84.22%@@ master #13311 diff @@
==========================================
Files 138 138
Lines 50666 50667 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 42672 42672
- Misses 7994 7995 +1
Partials 0 0
|
| self.tsAssertEqual(self.TS1, rhs_pre['x1']) | ||
| self.tsAssertEqual(self.TS2[:3].astype(np.float64), lhs, | ||
| check_names=False) | ||
| self.tsAssertEqual(self.TS1.astype(np.float64), rhs['x1'], |
There was a problem hiding this comment.
odd that we have tsAssertEqual, but ok as this module is deprecated.
|
thanks! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff2 changes to make tests more strict:
assert_numpy_array_equalnow checks input isnp.ndarrayassert_almost_equalnow checks inputs are the same class.