ENH: Respect Key Ordering for OrderedDict List in DataFrame Init #13309
Conversation
Current coverage is 84.22%@@ master #13309 diff @@
==========================================
Files 138 138
Lines 50681 50666 -15
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 42682 42672 -10
+ Misses 7999 7994 -5
Partials 0 0
|
| @@ -5537,7 +5537,8 @@ def _list_of_series_to_arrays(data, columns, coerce_float=False, dtype=None): | |||
| def _list_of_dict_to_arrays(data, columns, coerce_float=False, dtype=None): | |||
| if columns is None: | |||
| gen = (list(x.keys()) for x in data) | |||
| columns = lib.fast_unique_multiple_list_gen(gen) | |||
| columns = lib.fast_unique_multiple_list_gen( | |||
| gen, sort=(not isinstance(data[0], OrderedDict))) | |||
There was a problem hiding this comment.
should be not any(isinstance(d, OrderedDict) for d in data) I think. (a bit odd if that actually happens, though)
gfyoung
force-pushed
the
ordereddict-key-ordering-init
branch
4 times, most recently
from
54b4f9a to
448eee8
Compare
|
|
||
| row_three = {'b': 2, 'a': 1} | ||
|
|
||
| expected = DataFrame([[2, 1], [2, 1]], columns=['b', 'a']) |
There was a problem hiding this comment.
does this hit your code path? e.g. columns is not None here.
There was a problem hiding this comment.
That statement does not because no dict objects are being passed in.
There was a problem hiding this comment.
still need a test for a mix of dict/OrderedDIct being passed.
There was a problem hiding this comment.
Yeah, that's my last test (see below)
gfyoung
force-pushed
the
ordereddict-key-ordering-init
branch
2 times, most recently
from
27b7a69 to
2a600fc
Compare
gfyoung
force-pushed
the
ordereddict-key-ordering-init
branch
from
2a600fc to
4f311cc
Compare
|
@jreback : Travis is giving the green light. Ready to merge if there are no other concerns. |
| data['b'] = 2 | ||
| data['a'] = 1 | ||
|
|
||
| result = DataFrame([data]) |
There was a problem hiding this comment.
like this, but for example have a dict and OrderedDict in a list
|
ty sir! |
Title is self-explanatory. Closes #13304.