Skip to content

Change get_dummies() to return columns of dtype=bool instead of np.float64 #13283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Change get_dummies() to return columns of dtype=bool instead of np.float64 #13283

wants to merge 2 commits into from

Conversation

avishaylivne
Copy link

@avishaylivne
PERF: get_dummies return bool columns
135f4b1 
Make get_dummies() return columns of dtype=bool instead of np.float64
BUG: dtype compat with get_dummies pandas-dev#8725
pandas-dev#8725

Since all the point of this method is to return binary features there's no point to waste RAM and represent them using floats
@avishaylivne
Apply dtype=bool to early stages of get_dummies
1ec461f
@jreback
Copy link
Contributor

jreback commented May 25, 2016

tests!

further this needs careful examination to see if you are copying things.

@jreback jreback added Reshaping Concat, Merge/Join, Stack/Unstack, Explode Dtype Conversions Unexpected or buggy dtype conversions Categorical Categorical Data Type labels May 25, 2016
@jreback
Copy link
Contributor

jreback commented May 31, 2016

needs tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Categorical Categorical Data Type Dtype Conversions Unexpected or buggy dtype conversions Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: dtype compat with get_dummies
2 participants
@avishaylivne @jreback