Skip to content

ENH: support decimal argument in read_html #12907 #13272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

ENH: support decimal argument in read_html #12907 #13272

wants to merge 2 commits into from

Conversation

ccronca
Copy link
Contributor

@ccronca ccronca commented May 24, 2016

jreback
jreback reviewed May 24, 2016
View reviewed changes
pandas/io/html.py
decimal : str, default '.'
Character to recognize as decimal point (e.g. use ',' for European
data).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a versionadded tag here

@jreback jreback added Enhancement IO HTML read_html, to_html, Styler.apply, Styler.applymap labels May 24, 2016
@ccronca
Copy link
Contributor Author

ccronca commented May 25, 2016

@jreback please review latest commit

@jreback
Copy link
Contributor

jreback commented May 25, 2016

this looks good.

Do you have a site that this would work on? (I always like to manually test things as well)

@jreback jreback added this to the 0.18.2 milestone May 25, 2016
@ccronca
Copy link
Contributor Author

ccronca commented May 26, 2016

@jreback I have generated some data here: http://www.googledrive.com/host/0BzJmIC7_SNINRGxSUlhaT2hBeEk

It should work with:
df1 = pandas.read_html(url, decimal=',', thousands='.', header=1)

@jreback jreback closed this in 0f1666d May 27, 2016
@jreback
Copy link
Contributor

jreback commented May 27, 2016

thanks @camilocot great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement IO HTML read_html, to_html, Styler.apply, Styler.applymap
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.

read_html: support "decimal" argument for parsing numbers, like read_csv
2 participants
@ccronca @jreback