Skip to content

TST/CLN: remove np.assert_equal #13263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sinhrks
Copy link
Member

@sinhrks sinhrks commented May 23, 2016

  • tests added / passed
  • passes git diff upstream/master | flake8 --diff

Not to use np.testing.assert_equal, as assert_numpy_array_equal is more strict to check dtypes.

@sinhrks sinhrks added the Testing pandas testing functions or related to the test suite label May 23, 2016
@sinhrks sinhrks added this to the 0.18.2 milestone May 23, 2016
@jreback
Copy link
Contributor

jreback commented May 23, 2016

I think we need to add something to maybe the lint.sh script to prevent anything np.testing from slipping back in

maybe a recursive grep would work?

@jreback
Copy link
Contributor

jreback commented May 23, 2016

I think we could do something like this; if these are fixed (then just test if this grep outputs any lines, if so fail the lint.sh)

[Mon May 23 19:33:26 ~/pandas]$ grep -r --include '*.py' --exclude nosetester.py 'from numpy.testing import' pandas 
pandas/computation/tests/test_eval.py:from numpy.testing import assert_allclose
pandas/io/tests/json/test_ujson.py:from numpy.testing import (assert_array_almost_equal_nulp,
pandas/stats/tests/test_var.py:from numpy.testing import run_module_suite, TestCase
pandas/tests/test_graphics.py:from numpy.testing import assert_allclose
pandas/tseries/tests/test_converter.py:from numpy.testing import assert_almost_equal as np_assert_almost_equal
pandas/tseries/tests/test_timedeltas.py:from numpy.testing import assert_allclose

@sinhrks sinhrks force-pushed the test_assert_equal branch 3 times, most recently from a9c3589 to d400c6b Compare May 25, 2016 22:42
@sinhrks sinhrks force-pushed the test_assert_equal branch from d400c6b to a5b2a67 Compare May 26, 2016 14:13
@jreback jreback closed this in 9662d91 May 26, 2016
@jreback
Copy link
Contributor

jreback commented May 26, 2016

thanks @sinhrks nice cleanup

@sinhrks sinhrks deleted the test_assert_equal branch May 26, 2016 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants