Numindexname #13205

toobaz · 2016-05-17T15:46:18Z

closes Int64Index and Float64Index (and... ?) do not propagate name of passed index #12309
tests added / passed
passes git diff upstream/master | flake8 --diff
whatsnew entries: name passing, unsupported dtypes, copy=true for DateTimeIndex

This is a rebased & updated version of #12331

I would say the last commit is the most critical one: it exposes the consequences of making numeric indices only support their default dtype. By the way: I had interpreted your comment as "raise if dtype is set", but I don't think this is what we want, since it breaks the obj -> str(obj) -> obj roundtrip. So I raise only if dtype is not the expected dtype.

jreback · 2016-05-17T17:44:27Z

pandas/tests/indexes/test_numeric.py

-            expected = Index(i.values.astype(dtype))
-            tm.assert_index_equal(result, expected)
+        i = Float64Index([0, 1, 2])
+        result = i.astype('int64')


you can't change this. a float32 should simply be promoted to float64 (and likewise int32 to int64)

(right, fixed)

jreback · 2016-05-17T18:36:50Z

pandas/indexes/multi.py

+        if name is None and hasattr(levels, 'name'):
+            name = levels.name
+        if isinstance(levels, MultiIndex):
+            return levels.copy(name=name, names=names, deep=copy)


what is this needed for? passing a levels multi-index is very odd

I assumed we want idx.__class__(idx) to return a copy of idx for any index idx. But maybe it was just my fantasy...

well did you test this? if this were to be supported then it should be the very first check.

I am not averse (and other Indexes do this), but needs testing.

It is tested here

codecov-io · 2016-05-17T18:39:59Z

Current coverage is 84.25%

Merging #13205 into master will increase coverage by 0.01%

@@             master     #13205   diff @@
==========================================
  Files           138        138          
  Lines         50805      50810     +5   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          42796      42810    +14   
+ Misses         8009       8000     -9   
  Partials          0          0

Powered by Codecov. Last updated by 62b4327...9d93fea

jreback · 2016-05-17T18:40:26Z

pandas/indexes/numeric.py

+        if copy or data.dtype != cls._default_dtype:
+            subarr = np.array(data, dtype=cls._default_dtype, copy=copy)
+            if not ((subarr == data) | np.isnan(subarr)).all():
+                raise TypeError('Unsafe NumPy casting, you must '


this is extremely expensive to compare things like this,why are you doingit?

toobaz · 2016-05-17T19:54:52Z

Removed dtype check and the related tests. Sorry for filling up the Travis queue... three of the tests can be canceled.

jreback · 2016-05-17T21:54:40Z

pandas/indexes/multi.py

@@ -82,8 +84,6 @@ def __new__(cls, levels=None, labels=None, sortorder=None, names=None,
        if len(levels) == 1:
            if names:
                name = names[0]
-            else:


why are you removing this? names/name are equivalent (I think this is taken care above), pls confirm.

toobaz · 2016-05-18T07:16:32Z

(removed code for name handling in MultiIndex, which is now special-cased in the relative test)

jreback · 2016-05-18T13:30:41Z

pandas/tests/indexes/common.py

+    def test_ensure_copied_data(self):
+        # GH12309
+        for name, index in compat.iteritems(self.indices):
+            if isinstance(index, (PeriodIndex, RangeIndex, MultiIndex)):


so then these need specific tests (name this the same as this one and put in the appropriate place)

jreback · 2016-06-01T12:13:20Z

pandas/indexes/base.py

+        ----------
+        orig : ndarray
+            other ndarray to compare self._data against
+        copy : boolean


make this a default parameter of False.

toobaz · 2016-06-05T06:42:06Z

Added the new tests, will have to update a couple of calls when we decide what to do in #13355, but that can be done there, and I wouldn't wait (at least, I personally don't want to spend more time on this PR).

jreback · 2016-06-05T14:13:39Z

@toobaz no this looks fine. just wanted @sinhrks to have a look.

jreback · 2016-06-05T14:14:16Z

#13355 can fix it if desired (but to be honest that is lessening the strictness of tests), but can decide there.

jreback · 2016-06-05T14:15:07Z

pandas/tests/test_testing.py

+        with assertRaisesRegexp(AssertionError, expected):
+            assert_numpy_array_equal(a, b, check_same='same')
+        expected = 'array\(\[1, 2, 3\]\) is array\(\[1, 2, 3\]\)'
+        with assertRaisesRegexp(AssertionError, expected):


toobaz · 2016-06-12T06:47:36Z

ping @sinhrks

sinhrks · 2016-06-12T11:48:59Z

doc/source/whatsnew/v0.18.2.txt

@@ -343,7 +343,8 @@ Bug Fixes
 - Bug in ``.tz_convert`` on a tz-aware ``DateTimeIndex`` that relied on index being sorted for correct results (:issue: `13306`)


-
+- Bug in various index types, which did not propagate the name of passed index (:issue:`12309`)
+- Bug in ``DateTimeIndex``, which did not honour the ``copy=True`` (:issue:`13205`)


DatetimeIndex

sinhrks · 2016-06-12T11:57:23Z

Thx for update. Few minor comments.

closes pandas-dev#12309

toobaz · 2016-06-12T20:01:11Z

@sinhrks done, thanks

toobaz · 2016-06-14T07:47:56Z

( @jreback : I think we're ready)

jreback · 2016-06-14T13:54:46Z

thanks @toobaz the internal refactorings can take some time. great for sticking with it!

toobaz · 2016-06-14T14:08:54Z

Hope I've learned a bit that will help me need less passages next time ;-)

jreback reviewed May 17, 2016
View reviewed changes

jreback added Indexing Related to indexing on series/frames, not to indexes themselves Compat pandas objects compatability with Numpy or Python functions labels May 17, 2016

jreback reviewed May 17, 2016
View reviewed changes

toobaz force-pushed the numindexname branch 3 times, most recently from 8b6b37a to 62ec329 Compare May 17, 2016 19:29

toobaz force-pushed the numindexname branch from 62ec329 to 4001eab Compare May 17, 2016 19:56

jreback reviewed May 17, 2016
View reviewed changes

toobaz force-pushed the numindexname branch 2 times, most recently from 3479f9b to fe55399 Compare May 18, 2016 07:13

toobaz force-pushed the numindexname branch 2 times, most recently from 40cd25b to 798b23f Compare May 18, 2016 07:23

jreback reviewed May 18, 2016
View reviewed changes

jreback reviewed Jun 1, 2016
View reviewed changes

jreback added this to the 0.18.2 milestone Jun 1, 2016

toobaz force-pushed the numindexname branch from 7133525 to 883042c Compare June 1, 2016 12:54

toobaz mentioned this pull request Jun 3, 2016

BUG: revert assert_numpy_array_equal to before c2ea8fb2 (accept non-ndarrays) #13355

Closed

2 tasks

toobaz force-pushed the numindexname branch from 883042c to 47b6fa9 Compare June 5, 2016 06:12

jreback reviewed Jun 5, 2016
View reviewed changes

sinhrks reviewed Jun 12, 2016
View reviewed changes

toobaz added 6 commits June 12, 2016 15:21

BUG: Common NumericIndex.__new__, fixed name handling in indices

b6c9233

closes pandas-dev#12309

BUG: It makes sense to also catch ValueErrors

6d75e55

TST: Use assert_numpy_array_equal

757d105

DOC: What's new

3320727

BUG: Make DateTimeIndex copy datetime64[ns] data on copy=True

bea8101

TST: test "check_same" in assert_numpy_array_equal()

9d93fea

toobaz force-pushed the numindexname branch from 47b6fa9 to 9d93fea Compare June 12, 2016 16:25

jreback closed this in 07761c5 Jun 14, 2016

toobaz deleted the numindexname branch July 26, 2016 07:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Numindexname #13205

Numindexname #13205

toobaz commented May 17, 2016 •

edited

Loading

jreback May 17, 2016

toobaz May 17, 2016

jreback May 17, 2016

toobaz May 17, 2016

jreback May 17, 2016

toobaz May 18, 2016

codecov-io commented May 17, 2016 •

edited

Loading

jreback May 17, 2016

toobaz commented May 17, 2016 •

edited

Loading

jreback May 17, 2016

toobaz commented May 18, 2016

jreback May 18, 2016

jreback Jun 1, 2016

toobaz commented Jun 5, 2016

jreback commented Jun 5, 2016

jreback commented Jun 5, 2016

jreback Jun 5, 2016

toobaz commented Jun 12, 2016

sinhrks Jun 12, 2016

sinhrks commented Jun 12, 2016

toobaz commented Jun 12, 2016

toobaz commented Jun 14, 2016

jreback commented Jun 14, 2016

toobaz commented Jun 14, 2016

Numindexname #13205

Numindexname #13205

Conversation

toobaz commented May 17, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented May 17, 2016 • edited Loading

Current coverage is 84.25%

Choose a reason for hiding this comment

toobaz commented May 17, 2016 • edited Loading

Choose a reason for hiding this comment

toobaz commented May 18, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

toobaz commented Jun 5, 2016

jreback commented Jun 5, 2016

jreback commented Jun 5, 2016

Choose a reason for hiding this comment

toobaz commented Jun 12, 2016

Choose a reason for hiding this comment

sinhrks commented Jun 12, 2016

toobaz commented Jun 12, 2016

toobaz commented Jun 14, 2016

jreback commented Jun 14, 2016

toobaz commented Jun 14, 2016

toobaz commented May 17, 2016 •

edited

Loading

codecov-io commented May 17, 2016 •

edited

Loading

toobaz commented May 17, 2016 •

edited

Loading