Skip to content

CLN: no return on init #13197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

CLN: no return on init #13197

wants to merge 1 commit into from

Conversation

max-sixty
Copy link
Contributor

__init__ shouldn't return anything

@jreback
Copy link
Contributor

jreback commented May 17, 2016

its odd that nothing borks at this, e.g. python itself, linter. what showed this issue ?

@jreback jreback added the Compat pandas objects compatability with Numpy or Python functions label May 17, 2016
@jreback jreback added this to the 0.18.2 milestone May 17, 2016
@jreback jreback closed this in 62fc481 May 17, 2016
@max-sixty
Copy link
Contributor Author

@jreback yeah, I think it's just like returning None.
No tool caught it actually - just saw it as I was updating PRs. Surprised lint didn't.

@max-sixty max-sixty deleted the init-return branch May 18, 2016 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.
2 participants
@max-sixty @jreback