Skip to content

COMPAT: boto import issues #13136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

COMPAT: boto import issues #13136

wants to merge 1 commit into from

Conversation

jreback
Copy link
Contributor

@jreback jreback commented May 11, 2016

No description provided.

@jreback jreback added the Compat pandas objects compatability with Numpy or Python functions label May 11, 2016
@jreback jreback added this to the 0.18.2 milestone May 11, 2016
@jreback
Copy link
Contributor Author

jreback commented May 11, 2016

@TomAugspurger any progress on #11915

for boto to release a broken version is really annoying.

@jreback
Copy link
Contributor Author

jreback commented May 11, 2016

@TomAugspurger I just moved this all to a better location which at worse case would only raise on actual s3 import, rather than at pandas import time. I think this will also make integrating via s3fs slightly easier.

lmk.

@TomAugspurger
Copy link
Contributor

K, rebasing on those changes is test_parser.py right now. I think I was pretty close to having it working. Will put up a PR this morning.

@codecov-io
Copy link

codecov-io commented May 11, 2016

Current coverage is 84.14%

Merging #13136 into master will increase coverage by +<.01%

@@             master     #13136   diff @@
==========================================
  Files           137        137          
  Lines         50287      50285     -2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          42312      42311     -1   
+ Misses         7975       7974     -1   
  Partials          0          0          

Powered by Codecov. Last updated by 43989fd...75e3ef1

@jreback
Copy link
Contributor Author

jreback commented May 11, 2016

I have revised a bit. certainly ok with you making whatever changes, just want to get this out of the main import path.

@jreback
Copy link
Contributor Author

jreback commented May 11, 2016

@TomAugspurger any issue with this reorg? (I think your PR should easily go on top of this). hopefully can add more test coverage :)

@TomAugspurger
Copy link
Contributor

Yeah, +1 on this I think.

@jreback
Copy link
Contributor Author

jreback commented May 11, 2016

@TomAugspurger gr8.

@jreback jreback closed this in f0e47a9 May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants