-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
COMPAT: boto import issues #13136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COMPAT: boto import issues #13136
Conversation
@TomAugspurger any progress on #11915 for |
@TomAugspurger I just moved this all to a better location which at worse case would only raise on actual s3 import, rather than at pandas import time. I think this will also make integrating via s3fs slightly easier. lmk. |
K, rebasing on those changes is |
Current coverage is 84.14%@@ master #13136 diff @@
==========================================
Files 137 137
Lines 50287 50285 -2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 42312 42311 -1
+ Misses 7975 7974 -1
Partials 0 0
|
I have revised a bit. certainly ok with you making whatever changes, just want to get this out of the main import path. |
@TomAugspurger any issue with this reorg? (I think your PR should easily go on top of this). hopefully can add more test coverage :) |
Yeah, +1 on this I think. |
@TomAugspurger gr8. |
No description provided.