DOC: add warning section in indexing docs. #13060
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangxiangnick
changed the title
|
|
||
| df.loc[:,['B', 'A']] = df.loc[:,['A', 'B']] | ||
|
|
||
| ``df`` is not modified. The alignment is ignored in column assignment. |
There was a problem hiding this comment.
It would maybe be good to also give an illustration of the last sentence
|
yeah this needs a bit more documentation of why this doesn't work and then what you should do instead. |
jreback
added
Docs
Indexing
For assigning part of a DataFrame, explain why the assignment may not work and then the correct way to do it.
Current coverage is 84.14%@@ master #13060 diff @@
==========================================
Files 137 137
Lines 50227 50227
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 42261 42261
Misses 7966 7966
Partials 0 0
|
|
Add why the DataFrame assignment may not work and then the correct to do it. Anything else I can do? |
| @@ -191,6 +191,29 @@ raised. Multiple columns can also be set in this manner: | |||
| You may find this useful for applying a transform (in-place) to a subset of the | |||
| columns. | |||
|
|
|||
| .. warning:: | |||
|
|
|||
| pandas aligns index for setting a ``DataFrame`` from ``.loc``, ``.iloc`` and ``.ix``. | |||
There was a problem hiding this comment.
aligns for when setting (not specific to DataFrame)
jreback
pushed a commit
that referenced
this pull request
May 7, 2016
Replace PR #13060 close #12947 Author: Xiang Zhang <[email protected]> Closes #13070 from zhangxiangnick/doc_indexing_v2 and squashes the following commits: f9ade87 [Xiang Zhang] add warning section in indexing doc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add warning section in indexing docs. Close #12947.